|
Post by jdunlap on Jan 24, 2021 2:56:25 GMT
Hi Jamis!
I've been working on implementing BVH using your bonus chapter and came across the test for "Partitioning a group's children." In that test, you specify that after partitioning, g should be a group of [s3]. However, as I understand the meaning, partition merely returns a list of shapes to be moved, it doesn't actually move them -- that is done in divide, so this test seems to be incorrect at this point unless I am reading it incorrectly.
Your thoughts?
|
|
|
Post by Jamis on Mar 3, 2021 3:08:52 GMT
Hello!
Just to be clear, when you say "partition...doesn't actually move them", you are referring to "moving them out of the group", right?
The paragraph immediately before the test you mention has this to say (emphasis added):
So, the partition_children function is defined to have the side-effect of modifying its argument as it classifies the elements of the given group. Does that make sense? Or did I answer the wrong question?
- Jamis
|
|
|
Post by jdunlap on Mar 4, 2021 3:53:43 GMT
Thanks, Jamis, that was exactly what I was saying. I somehow missed that in the paragraph before.
|
|